Use IMessage type instead of any to define the type of message property
#861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #861 +/- ##
=======================================
Coverage 43.17% 43.17%
=======================================
Files 20 20
Lines 498 498
Branches 104 104
=======================================
Hits 215 215
Misses 216 216
Partials 67 67Continue to review full report at Codecov.
|
chilinh
added a commit
to chilinh/react-native-gifted-chat
that referenced
this pull request
Jul 18, 2018
* r_master: Use IMessage type instead of `any` to define the type of message property (FaridSafi#861) chore(package): update prop-types to version 15.6.2 (FaridSafi#907) fix(package): update uuid to version 3.3.0 (FaridSafi#913) Update InputToolbar.js (FaridSafi#906) Improved typings (FaridSafi#916) fix: enable renderFooter for FlatList MessageContainer (FaridSafi#914) # Conflicts: # index.d.ts
jessestuart
pushed a commit
to jessestuart/react-native-gifted-chat
that referenced
this pull request
Aug 9, 2018
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I'm using react-native-gifted-chat with TypeScript. I want
messagesproperty of GiftedChat component to have a type.I considered to write new Interface but found
IMessagetype in the type definition file. It looks good to use as type ofmessagesproperty.Thanks.